[codex] polish hero loading and footer layout#81
Conversation
ilyar
left a comment
There was a problem hiding this comment.
Reviewed the PR diff, GitHub checks, local quality gate, and desktop/mobile runtime behavior. No blocking issues found.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f16102160e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .preboot__fallback{max-width:760px;color:#f4efe2;line-height:1.6;} | ||
| .preboot__fallback a{color:#f1b800;} | ||
| .has-js .preboot__brand{display:inline-flex;} | ||
| .has-js .preboot__fallback{display:none;} |
There was a problem hiding this comment.
Keep the fallback visible until the app mounts
When JavaScript is enabled but /src/main.tsx is slow, blocked, or fails to load, this rule hides the only real fallback content while the replacement brand is aria-hidden, leaving crawlers, URL scanners, and assistive tech with an effectively empty page; if the module never runs, visitors are stuck on a decorative loader instead of the static Ever Guild content. Hide the fallback only once React has mounted or keep it accessible during preboot.
Useful? React with 👍 / 👎.
| <Suspense fallback={<DeferredSectionsFallback />}> | ||
| <Team /> | ||
| <Services /> | ||
| <Contact /> | ||
| </Suspense> |
There was a problem hiding this comment.
Preserve anchors while deferred sections load
When the Team/Services chunks are still loading, this Suspense fallback renders no #team or #services elements, so clicking the fixed navbar links during that window only updates the hash and the browser has no target to scroll to; after the lazy section mounts, native fragment scrolling is not retried. Keep lightweight anchor shells with these ids outside the Suspense boundary, or explicitly handle the pending hash after the sections load.
Useful? React with 👍 / 👎.
| grid-template-columns: minmax(0, 40rem) minmax(28rem, 1fr); | ||
| gap: clamp(1.5rem, 4vw, 5rem); |
There was a problem hiding this comment.
Stack hero facts before the field is wide enough
At common narrow-desktop widths such as 1024–1366px, this two-column layout leaves the signal field around 28–32rem wide while each absolute fact card has a 16.4rem minimum width and the first two cards are positioned at left: 8% and right: 4%; their horizontal ranges overlap, and their top offsets also overlap vertically. The stacked tablet rules only start below 1024px, so those viewports render colliding hero fact cards instead of the intended glass-card layout.
Useful? React with 👍 / 👎.
Summary
DESIGN.mdwith the current Ever Guild visual contract and implementation rules.Validation
npm run lintnpm run acceptance:test� 31 passednpm run lighthouse