-
Notifications
You must be signed in to change notification settings - Fork 255
feat: structured benchmark result output via BENCH_RESULT_OUTPUT #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
23d0718
feat(benchmarking): add structured result output via BENCH_RESULT_OUTPUT
chatton 3d8a60a
fix: address PR review feedback for structured benchmark output
chatton 3dc3e35
Merge branch 'main' into cian/benchmark-results-artifact
chatton c0592ee
refactor: make spamoor config fully configurable via BENCH_* env vars
chatton a941a30
feat: extract host metadata from OTEL resource attributes in trace spans
chatton c55bec1
fix: defer emitRunResult so results are written even on test failure
chatton 2bab161
fix: state pressure benchmark CI failure and align with other tests
chatton bab7a5f
fix: use deployment-level service names for trace queries in external…
chatton f2936c8
perf: use limit=1 for resource attribute trace queries
chatton 1028b10
Merge branch 'main' into cian/benchmark-results-artifact
chatton 41a4e40
Merge branch 'main' into cian/benchmark-results-artifact
chatton 3fb75ee
docs: add missing doc comments to run_result.go functions
chatton f0eb3a7
Merge branch 'main' into cian/benchmark-results-artifact
chatton f0f71bd
Merge branch 'main' into cian/benchmark-results-artifact
chatton 9012f2f
Merge branch 'main' into cian/benchmark-results-artifact
chatton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reject negative
BENCH_*load knobs up front.envIntaccepts-1here, somax_pending,rebroadcast, and the fee fields can go negative and only fail much later inside Spamoor. Validate or clamp these values when buildingbenchConfigso misconfigured runs fail fast.Possible fix
📝 Committable suggestion
🤖 Prompt for AI Agents