chore(deps): upgrade Go version to 1.25 + use latest stable otel semconv#74
Merged
obitech merged 2 commits intoexaring:mainfrom Apr 17, 2026
Merged
Conversation
- use `db.system.name` instead of `db.system` - use in-house `dbconv.ClientOperationDuration` struct to record operation duration metrics Signed-off-by: ValentinLvr <valentin.levier@outlook.com>
This was referenced Apr 13, 2026
Contributor
Author
There was a problem hiding this comment.
Pull request overview
Updates otelpgx to newer Go and OpenTelemetry semantic conventions, addressing deprecated DB attributes and correcting operation duration metric recording.
Changes:
- Bump minimum Go version to 1.25.0 and update OpenTelemetry dependencies.
- Replace deprecated
db.systemusage withdb.system.namesemconv attributes. - Switch operation duration metric to
dbconv.ClientOperationDurationand record durations in seconds.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tracer.go | Updates semconv usage and switches operation duration metric to dbconv (seconds). |
| meter.go | Updates semconv and removes redundant DB system attribute from appended pool attrs. |
| go.mod | Raises minimum Go version and updates OTEL module versions. |
| go.sum | Refreshes dependency checksums for updated modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
obitech
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use
db.system.nameinstead ofdb.systemuse in-house
dbconv.ClientOperationDurationstruct to record operation duration metrics (now in seconds vs miliseconds)fixes #75, #70
BREAKING CHANGES since we are changing the minimum go version + change attribute semconv + change operation duration metric unit from miliseconds to seconds as metric name was misleading.
We are still in v0.X.X it's fine though (only a minor bump is needed)