Skip to content

🐛 FIX: render hardbreak and inline HTML in image alt text #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chuenchen309 wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −1
Open

🐛 FIX: render hardbreak and inline HTML in image alt text #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion markdown_it/renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ def renderInlineAsText(
elif token.type == "image":
if token.children:
result += self.renderInlineAsText(token.children, options, env)
elif token.type == "softbreak":
elif token.type in ("html_inline", "html_block"):
result += token.content
elif token.type in ("softbreak", "hardbreak"):
result += "\n"

return result
Expand Down
16 changes: 16 additions & 0 deletions tests/test_port/fixtures/commonmark_extras.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,3 +749,19 @@ Issue #204. Combination of blockquotes, list and newlines causes an IndexError
</li>
</ul>
.

Hardbreak in image description
.
![foo\
bar](/url)
.
<p><img src="/url" alt="foo
bar" /></p>
.

Inline HTML in image description
.
![a<b>c](/url)
.
<p><img src="/url" alt="a&lt;b&gt;c" /></p>
.