[eas-cli] Improve build request error details#3982
Open
szdziedzic wants to merge 2 commits into
Open
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Contributor
Author
|
/changelog-entry bug-fix Improve EAS Build request failures to include network and HTTP response details when GraphQL errors are empty. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3982 +/- ##
==========================================
+ Coverage 59.33% 59.41% +0.08%
==========================================
Files 936 936
Lines 41172 41258 +86
Branches 8671 8699 +28
==========================================
+ Hits 24424 24508 +84
- Misses 16654 16656 +2
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
tsapeta
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Build request failures can currently hide useful underlying details when the GraphQL client returns an empty
graphQLErrorsarray. In the reported case,EXPO_DEBUG=1only surfaced[], while the user-facing error stayed generic despite the HTTP 400 response carrying more context.How
Updated
handleBuildRequestErrorto preserve existing friendly handling for known server-side EAS error codes, while enriching the generic build request failure path with network error messages, HTTP response status, and request IDs when available.Also changed debug logging to emit structured build request details, including GraphQL errors, network error fields, response status/url, and selected safe response headers.
Test Plan
./node_modules/.bin/oxfmt .corepack yarn test src/build/__tests__/handleBuildRequestError-test.tscorepack yarn workspace eas-cli typecheck