Skip to content

[eas-cli] Improve build request error details#3982

Open
szdziedzic wants to merge 2 commits into
mainfrom
szdziedzic-codex/improve-build-request-errors
Open

[eas-cli] Improve build request error details#3982
szdziedzic wants to merge 2 commits into
mainfrom
szdziedzic-codex/improve-build-request-errors

Conversation

@szdziedzic

Copy link
Copy Markdown
Contributor

Why

Build request failures can currently hide useful underlying details when the GraphQL client returns an empty graphQLErrors array. In the reported case, EXPO_DEBUG=1 only surfaced [], while the user-facing error stayed generic despite the HTTP 400 response carrying more context.

How

Updated handleBuildRequestError to preserve existing friendly handling for known server-side EAS error codes, while enriching the generic build request failure path with network error messages, HTTP response status, and request IDs when available.

Also changed debug logging to emit structured build request details, including GraphQL errors, network error fields, response status/url, and selected safe response headers.

Test Plan

  • ./node_modules/.bin/oxfmt .
  • corepack yarn test src/build/__tests__/handleBuildRequestError-test.ts
  • corepack yarn workspace eas-cli typecheck

@szdziedzic szdziedzic changed the title [codex] Improve build request error details [eas-cli] Improve build request error details Jul 7, 2026
@szdziedzic szdziedzic marked this pull request as ready for review July 7, 2026 12:24
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/build/** @sjchmiela

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@szdziedzic

Copy link
Copy Markdown
Contributor Author

/changelog-entry bug-fix Improve EAS Build request failures to include network and HTTP response details when GraphQL errors are empty.

@szdziedzic szdziedzic requested a review from tsapeta July 7, 2026 12:25
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.51163% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.41%. Comparing base (081e1a9) to head (6c32f94).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/build.ts 96.52% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3982      +/-   ##
==========================================
+ Coverage   59.33%   59.41%   +0.08%     
==========================================
  Files         936      936              
  Lines       41172    41258      +86     
  Branches     8671     8699      +28     
==========================================
+ Hits        24424    24508      +84     
- Misses      16654    16656       +2     
  Partials       94       94              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants