[build-tools] upload serve-sim metrics artifact on session teardown#3995
Draft
gwdp wants to merge 1 commit into
Draft
[build-tools] upload serve-sim metrics artifact on session teardown#3995gwdp wants to merge 1 commit into
gwdp wants to merge 1 commit into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
46a5eef to
88f253b
Compare
54257fd to
1230799
Compare
88f253b to
158b437
Compare
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gwdp/serve-sim-metrics-cors #3995 +/- ##
===============================================================
- Coverage 59.80% 59.65% -0.15%
===============================================================
Files 936 939 +3
Lines 41069 41299 +230
Branches 8639 8688 +49
===============================================================
+ Hits 24559 24632 +73
- Misses 16416 16573 +157
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
so a finished simulator session's CPU/memory shows up in the dashboard (the live stream is gone once the session ends).
How
at session teardown, lists serve-sim's
/artifacts, downloads the metrics NDJSON, and uploads it through the sameuploadDeviceRunSessionArtifactAsyncpath as other session artifacts. the file grows all session, so it's fetched once at the end rather than mid-session.Test Plan
CI passes. unit tests cover listing, download+upload, and the teardown drain.