Skip to content

[build-tools] Add simulator details to screen recording metadata#4000

Open
sjchmiela wants to merge 1 commit into
mainfrom
stanley/add-ios-screen-recording-device-metadata
Open

[build-tools] Add simulator details to screen recording metadata#4000
sjchmiela wants to merge 1 commit into
mainfrom
stanley/add-ios-screen-recording-device-metadata

Conversation

@sjchmiela

Copy link
Copy Markdown
Contributor

Summary

  • include the simulator device name and human-readable runtime name in Device Run Session screen recording metadata
  • carry those fields through the finish-step output and construct the artifact display name only during upload
  • normalize CoreSimulator runtime identifiers such as iOS-18-6 to iOS 18.6
  • add focused coverage for runtime normalization and the uploaded metadata payload

Why

The website needs device and runtime details to identify and present EAS-generated simulator screen recordings without parsing artifact names or CoreSimulator identifiers.

Validation

  • yarn workspace @expo/build-tools typecheck
  • yarn workspace @expo/build-tools jest-unit --runInBand src/utils/__tests__/IosSimulatorUtils.test.ts src/steps/functions/__tests__/uploadDeviceRunSessionScreenRecordings.test.ts

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Jul 10, 2026
@sjchmiela sjchmiela marked this pull request as ready for review July 10, 2026 20:10
@sjchmiela sjchmiela requested a review from szdziedzic July 10, 2026 20:10
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.72%. Comparing base (4b1f785) to head (42539e9).

Files with missing lines Patch % Lines
...ools/src/steps/utils/IosSimulatorRecordingUtils.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4000      +/-   ##
==========================================
+ Coverage   59.67%   59.72%   +0.05%     
==========================================
  Files         941      941              
  Lines       41319    41322       +3     
  Branches     8675     8676       +1     
==========================================
+ Hits        24654    24674      +20     
+ Misses      16571    16554      -17     
  Partials       94       94              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant