feat: allow field access on concrete types behind interface values#952
Open
snaffi wants to merge 4 commits into
Open
feat: allow field access on concrete types behind interface values#952snaffi wants to merge 4 commits into
snaffi wants to merge 4 commits into
Conversation
antonmedv
requested changes
Apr 13, 2026
| fk := f.Type.Kind() | ||
|
|
||
| // Dereference pointers to get to the underlying type. | ||
| for fk == reflect.Ptr { |
| return reflect.Value{}, reflect.StructField{}, false | ||
| } | ||
|
|
||
| func fetchFromEmbeddedInterfaces(v reflect.Value, fieldName string) (any, bool) { |
Member
There was a problem hiding this comment.
Will be nice to test this function in isolation. A better unit tests for this function, ideally with 100% coverage for this function.
…dedInterfaces Replace hand-rolled pointer/interface unwrap loops with deref.Value and deref.Type, consistent with how Fetch already dereferences values. Add white-box unit tests covering each branch (100% coverage of the function): plain struct, embedded interface with/without field, pointer to struct concrete value, nil concrete value, nil embedded pointer, nested embedded struct, nested embedded interface, non-struct concrete value, expr:"-" tag, and empty concrete struct.
Author
|
@antonmedv hello, I appologize for late response. Yours comments have been addressed. |
antonmedv
reviewed
May 19, 2026
| Title string | ||
| } | ||
|
|
||
| func TestFetchFromEmbeddedInterfaces(t *testing.T) { |
Member
There was a problem hiding this comment.
Member
|
Looks like something with tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#951