Skip to content

ci: build express with node.js v26#7218

Merged
bjohansebas merged 1 commit into
expressjs:masterfrom
shivarm:build-node26
May 17, 2026
Merged

ci: build express with node.js v26#7218
bjohansebas merged 1 commit into
expressjs:masterfrom
shivarm:build-node26

Conversation

@shivarm
Copy link
Copy Markdown
Contributor

@shivarm shivarm commented May 6, 2026

No description provided.

@krzysdz krzysdz added the github_actions Pull requests that update GitHub Actions code label May 6, 2026
@krzysdz
Copy link
Copy Markdown
Contributor

krzysdz commented May 6, 2026

I just tested Express locally with Node.js 26 and the tests won't even run, because of nodejs/node#62083 breaking the old version of yargs (nodejs/node#62083 (comment)), which is an indirect dependency of mocha. With latest mocha (11.7.5) tests pass.

@shivarm
Copy link
Copy Markdown
Contributor Author

shivarm commented May 6, 2026

@krzysdz Should I upgrade mocha and yargs

@krzysdz
Copy link
Copy Markdown
Contributor

krzysdz commented May 6, 2026

I think it can be done as a part of this PR. Only updating mocha in package.json is necessary:

diff --git a/package.json b/package.json
index 8c9efb56..16012b61 100644
--- a/package.json
+++ b/package.json
@@ -72,7 +72,7 @@
     "hbs": "4.2.0",
     "marked": "^15.0.3",
     "method-override": "3.0.0",
-    "mocha": "^10.7.3",
+    "mocha": "^11.7.5",
     "morgan": "1.10.1",
     "nyc": "^17.1.0",
     "pbkdf2-password": "1.2.1",

@shivarm
Copy link
Copy Markdown
Contributor Author

shivarm commented May 6, 2026

Thanks! Tests are passing

@krzysdz krzysdz added the dependencies Pull requests that update a dependency file label May 6, 2026
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedmocha@​10.8.2 ⏵ 11.7.59610095 +197100

View full report

@shivarm shivarm changed the title ci: build with node.js v26 ci: build express with node.js v26 May 6, 2026
@shivarm
Copy link
Copy Markdown
Contributor Author

shivarm commented May 9, 2026

Should we also remove node version 25 from matrix?

@krzysdz
Copy link
Copy Markdown
Contributor

krzysdz commented May 9, 2026

Should we also remove node version 25 from matrix?

No. Express supports node >= 18, so 18 and all later versions (even EOL) should be tested.

@bjohansebas bjohansebas merged commit f5c159b into expressjs:master May 17, 2026
30 checks passed
@shivarm shivarm deleted the build-node26 branch May 18, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants