Fix decoding for people over 100 years old. #203

Author: fabiocaccamo

src/codicefiscale/codicefiscale.py

@@ -474,21 +474,35 @@ def decode(code: str) -> dict[str, Any]:
     birthdate_year = int(f"{current_year_century_prefix}{birthdate_year_suffix}")
     if birthdate_year > current_year:
         birthdate_year -= 100
-    birthdate_str = f"{birthdate_year}/{birthdate_month}/{birthdate_day}"
-    birthdate = _get_date(birthdate_str, separator="/")
-    if not birthdate:
-        raise ValueError(f"[codicefiscale] invalid date: {birthdate_str}")
 
-    birthplace_code = raw["birthplace"][0] + raw["birthplace"][1:].translate(
-        _OMOCODIA_DECODE_TRANS
-    )
-    birthplace = _get_birthplace(birthplace_code, birthdate)
-    # print(birthplace)
-    if not birthplace:
-        raise ValueError(
-            "[codicefiscale] wrong birthplace code: "
-            f"{birthplace_code!r} / birthdate: {birthdate.isoformat()!r}."
-        )
+    birthdate_or_birthplace_error = None
+    for _ in range(2):
+        birthdate_str = f"{birthdate_year}/{birthdate_month}/{birthdate_day}"
+        try:
+            birthdate = _get_date(birthdate_str, separator="/")
+            if not birthdate:
+                raise ValueError(f"[codicefiscale] invalid date: {birthdate_str}")
+
+            birthplace_code = raw["birthplace"][0] + raw["birthplace"][1:].translate(
+                _OMOCODIA_DECODE_TRANS
+            )
+            birthplace = _get_birthplace(birthplace_code, birthdate)
+            # print(birthplace)
+            if not birthplace:
+                raise ValueError(
+                    "[codicefiscale] wrong birthplace code: "
+                    f"{birthplace_code!r} / birthdate: {birthdate.isoformat()!r}."
+                )
+            break
+        except ValueError as error:
+            # attempt to handle people over 100 years old
+            if birthdate_or_birthplace_error is None:
+                birthdate_or_birthplace_error = error
+            birthdate_year -= 100
+    else:
+        # raise the first raised error
+        if birthdate_or_birthplace_error:
+            raise birthdate_or_birthplace_error
 
     cin = raw["cin"]
     cin_check = encode_cin(code)

tests/issues/test_issue_0203.py

@@ -0,0 +1,44 @@
+import datetime
+
+from codicefiscale import codicefiscale
+
+
+def test_issue_0203():
+    """
+    Test for people over 100 years old.
+    https://github.com/fabiocaccamo/python-codicefiscale/issues/203
+    """
+    code = codicefiscale.encode("Michele", "Faedi", "m", "01/01/1907", "Gallico")
+    assert code == "MCHFDA07A01D877A"
+
+    code_data = codicefiscale.decode(code)
+    code_data.pop("omocodes", None)
+    expected_code_data = {
+        "code": "MCHFDA07A01D877A",
+        "gender": "M",
+        "birthdate": datetime.datetime(1907, 1, 1, 0, 0),
+        "birthplace": {
+            "active": False,
+            "code": "D877",
+            "date_created": "1861-03-17T00:00:00",
+            "date_deleted": "1927-08-02T00:00:00",
+            "name": "Gallico",
+            "name_alt": "",
+            "name_alt_trans": "",
+            "name_slugs": ["gallico"],
+            "name_trans": "Gallico",
+            "province": "RC",
+        },
+        "raw": {
+            "code": "MCHFDA07A01D877A",
+            "lastname": "MCH",
+            "firstname": "FDA",
+            "birthdate": "07A01",
+            "birthdate_year": "07",
+            "birthdate_month": "A",
+            "birthdate_day": "01",
+            "birthplace": "D877",
+            "cin": "A",
+        },
+    }
+    assert code_data == expected_code_data