Dedupe redundant serde attributes in pyrefly_config#4147
Open
jorenham wants to merge 1 commit into
Open
Conversation
Contributor
|
@samwgoldman has imported this pull request. If you are a Meta employee, you can view this in D112459848. |
yangdanny97
approved these changes
Jul 17, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every
Optionfield in the config structs repeated#[serde(default, skip_serializing_if = "Option::is_none")], and someflattenandskipfields also had adefaultthat serde ignores or already implicitly uses.This updates the config structs to use
#[skip_serializing_none]fromserde_withfor the entire struct, and removes the redundant serde stuff.Spotted while working on #4146.
Test Plan
Tests still pass; no behavior changes.