Fix suppressions after nested multiline f-strings#4175
Conversation
|
Hi @loulanyue! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
The lightweight scanner loses the surrounding single-quoted f-string context across physical lines. For a nested multiline string, its closing triple quotes can therefore be mistaken for a new top-level string opener, hiding a valid suppression on a later line. The scoped token fallback uses Python's actual lexical structure without parsing every module twice.
Fixes #4118.
Verification
cargo test -p pyrefly_python: 71 passed, 0 failedcargo test -p pyrefly_python ignore: 8 passed, 0 failedcargo clippy -p pyrefly_python --all-targets -- -D warnings: passedpython3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema: passed; existing unrelated warnings remain on Rust 1.97.1cargo run -p pyrefly -- check /tmp/pyrefly-4118-repro.py:0 errors (1 suppressed)git diff --check: passedAI disclosure
This contribution was prepared and reviewed with Codex acting as an AI coding agent. The issue reproduction, fallback scope, negative test, end-to-end behavior, formatting, tests, and lint results were explicitly verified before submission.