feat(suppress): add --remove-unused-type-ignores flag#4200
Open
tobyh-canva wants to merge 3 commits into
Open
Conversation
tobyh-canva
commented
Jul 18, 2026
Comment on lines
+582
to
+585
| pub fn remove_unused_ignores_from_serialized( | ||
| unused_ignore_errors: Vec<SerializedError>, | ||
| remove_unused_type_ignores: bool, | ||
| ) -> usize { |
Collaborator
Author
There was a problem hiding this comment.
This function is getting a bit unwieldy and I think the way ignore removal works might deserve a refactor in a future PR.
The type-checker flags an unused ignore, then the suppressor has to work backwards from the human-readable error message and parse the line with regex to discover which parts of the line to remove. The type-checker could instead record the precise information once when flagging the error, serialise it in a structured way, then the suppressor just does the rudimentary cleanup.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tobyh-canva
marked this pull request as ready for review
July 18, 2026 08:45
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
--remove-unused-type-ignoresflag topyrefly suppressandpyrefly check, which removes# type: ignorecomments in addition to# pyrefly: ignorecomments.Resolves #3984.