This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Fix scoreboard graph for new registrations#633
Open
JasonTarka wants to merge 1 commit intofacebookarchive:masterfrom
Open
Fix scoreboard graph for new registrations#633JasonTarka wants to merge 1 commit intofacebookarchive:masterfrom
JasonTarka wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
If a team registered after the game had started, their line would still start at the beginning of the graph, ending somewhere in the middle. Making the data use the iteration, rather than an arbitrary count, moves it to the proper temporal location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a team registered after the game had started, their line would still start at the beginning of the graph, ending somewhere in the middle. Making the data use the iteration, rather than an arbitrary count, moves it to the proper temporal location.