Fix typos in manifest error message and CSS inspector#384
Open
durvesh1992 wants to merge 1 commit into
Open
Conversation
- 'invalid version/typeon attribute' -> 'version/type on attribute' in the manifest validation error. - Rename scanForCSSNeedingManualInspsection -> ...Inspection (internal, all three call sites updated). - 'checked agains the manifest' -> 'against' comment fix.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small typo/readability cleanup:
getManifestVersionAndTypeFromNodethrewMissing manifest data attribute or invalid version/typeon attribute—typeonshould readtype on.scanForCSSNeedingManualInspsection→scanForCSSNeedingManualInspection. It is internal (defined inmanualCSSInspector.ts, imported and called once incontent.ts); all three sites are updated.Link style tags are checked agains the manifest→against.No behavior change.
Test plan
node --experimental-vm-modules ... jest --watchman=false: 10 suites, 92 tests pass, no regressions. Prettier clean.