feat(hive): Add runtime stats to HiveIndexSource and FileIndexReader (#16926)#16926
Closed
zacw7 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat(hive): Add runtime stats to HiveIndexSource and FileIndexReader (#16926)#16926zacw7 wants to merge 1 commit intofacebookincubator:mainfrom
zacw7 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
meta-codesync
Bot
changed the title
zacw7
force-pushed
the
export-D98183179
branch
2 times, most recently
from
1e64b07 to
6764d43
Compare
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Mar 27, 2026
…acebookincubator#16926) Summary: Adds performance metrics to the index lookup pipeline: - HiveIndexSource reports end-to-end iteration time (kConnectorLookupWallTime) and output projection time (kConnectorResultPrepareTime) using addOperatorRuntimeStats() for per-call granularity - FileIndexReader reports per-file lookup setup time, read I/O time, request count, and output row count - Adds kNumIndexSplits to IndexLookupJoin operator for split count tracking - Stats already tracked by IndexLookupJoin (numLookups, numOutputRows) are not duplicated Reviewed By: kewang1024 Differential Revision: D98183179
zacw7
force-pushed
the
export-D98183179
branch
2 times, most recently
from
0b2858d to
e800852
Compare
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Mar 30, 2026
…acebookincubator#16926) Summary: Adds performance metrics to the index lookup pipeline: - HiveIndexSource reports end-to-end iteration time (kConnectorLookupWallTime) and output projection time (kConnectorResultPrepareTime) using addOperatorRuntimeStats() for per-call granularity - FileIndexReader reports per-file lookup setup time, read I/O time, request count, and output row count - Adds kNumIndexSplits to IndexLookupJoin operator for split count tracking - Stats already tracked by IndexLookupJoin (numLookups, numOutputRows) are not duplicated Reviewed By: kewang1024 Differential Revision: D98183179
Build Impact AnalysisDirectly Changed Targets
Selective Build Targets (building these covers all 299 affected)Total affected: 299/555 targets
All affected targets (299)
Fast path • Graph from main@6f8658c4548b03d710d3eb0a54186257ef97a340 |
…acebookincubator#16926) Summary: Adds performance metrics to the index lookup pipeline: - HiveIndexSource reports end-to-end iteration time (kConnectorLookupWallTime) and output projection time (kConnectorResultPrepareTime) using addOperatorRuntimeStats() for per-call granularity - FileIndexReader reports per-file lookup setup time, read I/O time, request count, and output row count - Adds kNumIndexSplits to IndexLookupJoin operator for split count tracking - Stats already tracked by IndexLookupJoin (numLookups, numOutputRows) are not duplicated Reviewed By: kewang1024 Differential Revision: D98183179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds performance metrics to the index lookup pipeline:
Reviewed By: kewang1024
Differential Revision: D98183179