Skip to content

Fix misleading comments in commsOverlapBench overlap-pair-pgs (#222) #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MogicianWu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix misleading comments in commsOverlapBench overlap-pair-pgs (#222) #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion et_replay/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies = [
]

[tool.setuptools.package-dir]
"et_replay" = "et_replay"
"et_replay" = "."

[project.scripts]
comm_replay = "et_replay.tools.comm_replay:main"
Expand Down
8 changes: 4 additions & 4 deletions train/comms/pt/commsOverlapBench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ def readArgs(self, parser):
"--overlap-pair-pgs",
action="store_true",
default=False,
help="Toggle to enable overlapping collective pair with two pgs",
) # overlap collective pair with two pgs
help="Toggle to enable overlapping collectives with separate pgs, one per collective (main + pairs)",
)

# Check arguments that may be custmized per benchmark in a single run
# does not depend on data type
Expand Down Expand Up @@ -225,7 +225,7 @@ def runColl(self, comm_fn=None, comm_fn_pair_list=None, dcheck=False):
is_blocking=False,
timer=self.collectiveArgs.comm_dev_time,
):
# post another collecitve if on comms pair mode, otherwise it's noop
# post pair collective on a separate stream for overlapping evaluation
self.collectiveArgs.group = self.collectiveArgs.groups[
self.collectiveArgs.pairPgId[pairIdx]
]
Expand Down Expand Up @@ -890,7 +890,7 @@ def genMultiCommGroups(
self.backendFuncs.initialize_groups(backend)

elif pair and overlap_pair_pgs:
# create two communicators each including all ranks
# create 1 + len(pair_collectives_list) communicators each including all ranks
num_pgs = 1 + len(pair_collectives_list)
for pgId in range(0, num_pgs):
if pgId > 0:
Expand Down
Loading