Try to fix docker/build-push-action in PRs from external forks#413
Merged
ethanjli merged 15 commits intoMay 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix failure of
docker/build-push-actionin PRs made from external forks of the github.com/PlanktoScope/PlanktoScope repo, e.g. as in #402This PR initially attempted to take a different approach than PlanktoScope/device-backend#30 / PlanktoScope/device-backend#31 , by trying to make container images get published under the namespace of the user who owns the external fork. However, that didn't work, so this PR just takes the same approach as those PRs in device-backend: now this PR just disables pushing of container images from external forks.
This PR also refactors the CI workflows for readability & reusability.