planktoscopehat: Remove gps leftovers#608
Merged
Merged
Conversation
sonnyp
commented
May 13, 2025
| "node-red-contrib-cron-plus": "^2.1.0", | ||
| "node-red-contrib-dir2files": "^0.3.0", | ||
| "node-red-contrib-gpsd": "^1.0.4", | ||
| "node-red-contrib-python3-function": "^0.0.4", |
Collaborator
Author
There was a problem hiding this comment.
unused on the planktoscope flow
Collaborator
|
If we get consensus in tomorrow's meeting about whether to remove GPS support in the adafruithat images and whether that removal merits a deprecation-without-removal for one release cycle (i.e. for v2025.0.0), we can remove GPS-related stuff from adafruithat either in a separate future PR (if we choose to do a deprecation for v2025.0.0) or in this PR (if we choose to remove it without having deprecated it first). |
Collaborator
Author
|
I'll let you decide regarding adafruithat. I'll go ahead and merge this because node-red-contrib-gpsd is spamming logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftovers from #591
@ethanjli If you're interested the same thing can be done for adafruithat