Skip to content

Fix mobile Award collapse color#23

Merged
fanyangCS merged 3 commits into
masterfrom
fix-mobile-award-collapse-color
Jul 12, 2026
Merged

Fix mobile Award collapse color#23
fanyangCS merged 3 commits into
masterfrom
fix-mobile-award-collapse-color

Conversation

@fanyangCS

Copy link
Copy Markdown
Owner

Summary

  • restore the dark-coral Award palette after a second tap collapses the detail on touch devices
  • scope the override to (hover: none) and aria-expanded="false", preserving expanded and desktop hover states
  • apply consistently to both homepage and full publications surfaces

Verification

  • bundle exec jekyll build (Ruby 3.2 bundle; passes)
  • node --test test/theme_test.js (3/3 pass)
  • ruby test/cache_bust_test.rb (6 runs, 8 assertions, 0 failures)
  • npx prettier assets/css/main.scss --check
  • git diff --check
  • Chromium/Playwright at 390x900 touch viewport, homepage and /publications/: after expand then collapse, aria-expanded=false, detail .open=false, sticky :hover=true, and computed background/border/text are rgb(134, 69, 63) / rgb(134, 69, 63) / rgb(255, 250, 247)
  • Chromium/Playwright at 1280x900, both surfaces: desktop hover remains light coral rgb(231, 197, 191) and returns to dark coral rgb(134, 69, 63) when unhovered

AI-generated disclosure

GitHub Copilot assisted with diagnosis, implementation, verification, and PR drafting.

Override sticky touch :hover only for collapsed Award controls so the dark-coral palette returns after the second tap without changing desktop hover behavior.

AI-generated disclosure: GitHub Copilot assisted with diagnosis, implementation, and verification.
@fanyangCS
fanyangCS force-pushed the fix-mobile-award-collapse-color branch from bf9b7d6 to ea4079a Compare July 12, 2026 10:29
Restore Bib and Abs to their original master palettes after a second touch while retaining Award's existing dark-coral reset. Track the three disclosure states with aria-expanded so sticky hover can be overridden narrowly.

AI-generated disclosure: GitHub Copilot assisted with diagnosis, implementation, and verification.
@fanyangCS
fanyangCS merged commit 284e624 into master Jul 12, 2026
4 checks passed
@fanyangCS
fanyangCS deleted the fix-mobile-award-collapse-color branch July 12, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants