feat: windows添加任务完成或者需要确认右下角弹窗提醒#1635
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1c126bb13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb3e5705e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0acb93d356
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57d03e6692
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8f86e69bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44da65db3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f2f5218fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8473fad8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1364480bc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
farion1231
left a comment
farion1231
left a comment
There was a problem hiding this comment.
感谢你的贡献。请请查看一下是否有以下问题：
P1 PR 当前会让测试目标编不过。AppState 新增了 claude_notify_service 字段，但测试 fixture 还在用旧结构体字面量初始化，见 store.rs (line 7)、support.rs (line 63)、support.rs (line 71)、deeplink_import.rs (line 22)、deeplink_import.rs (line 62)。我在 PR head 上跑 cargo test --manifest-path src-tauri/Cargo.toml claude_notify，直接报 E0063 missing field claude_notify_service in initializer of AppState。
P2 后端错误消息是中文硬编码，最终会直接透传到前端，英文/日文环境下会看到中文报错。见 server.rs (line 135)、server.rs (line 152)、server.rs (line 166)、commands/claude_notify.rs (line 391)。
P2 save_settings 的回滚逻辑会吞掉原始错误。如果运行时同步失败后回滚也失败，用户只能看到回滚失败，拿不到真正的根因。见 settings.rs (line 33)。
P3 Windows-only 边界还没完全收紧。通知插件、命令注册、ClaudeNotifyService 初始化、.ps1 hooks 生成逻辑目前都是全平台可编译/可调用，只是“自动启动”在 Windows 下才加了 cfg。见 Cargo.toml (line 38)、lib.rs (line 233)、lib.rs (line 890)、lib.rs (line 695)。
P3 apply_claude_notify_hook_config 的 _port 参数是死参数，前端传了但后端完全忽略，接口语义有误导性。见 commands/claude_notify.rs (line 376)。
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
这轮主要是对当前已实现的 Claude 后台通知能力做补充收口，重点修了 5 个问题：
已补充验证：
补充说明：
|
2 participants
背景
当前在使用 Claude Code 时，如果终端窗口处于后台，用户很容易错过以下关键状态：
这类状态本身不是错误，但会明显影响后台执行时的可感知性与交互效率。
本次提交为 CC Switch 增加了一套 最小可用 的 Claude 后台通知能力：
本次实现内容
在设置页新增了 Claude 后台通知相关配置项：
并补充了以下交互约束：
在 Tauri 侧新增 Claude 通知服务模块，负责：
当前覆盖的事件包括：
其中：
本次实现支持由 CC Switch 直接管理用户级 Claude hooks：
这样可以避免要求用户手动编写复杂的 PowerShell 命令，同时尽量减少对项目仓库本身的侵入。
为通知功能新增了对应设置字段与默认值，并在设置保存后对运行态进行同步：
已补充：
包括：
设计取舍
为什么一期只支持 Windows
本次功能的一期范围仅覆盖 Windows，原因不是架构上排斥其他平台，而是当前仅具备 Windows
设备，无法对 Linux 和 Apple 平台进行实际验证。
为了避免提交“理论可用但未经验证”的跨平台实现，本次将范围收敛为：
测试与验证
本次已完成的验证包括：
静态检查
手动验证
影响范围
本次提交主要涉及以下部分：
本次 PR 已尽量控制提交范围，未包含与 Claude 后台通知无关的格式化噪音或过程文档。
备注
当前实现目标是 最小可用、可验证、可合并。
后续如需继续完善，比较自然的方向包括：