fix: analytics harness & identity detections#235
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Kinfe123
changed the title
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Kinfe123
changed the title
Contributor
There was a problem hiding this comment.
1 issue found across 7 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/docs/src/cloud-analytics.ts">
<violation number="1" location="packages/docs/src/cloud-analytics.ts:190">
P1: Agent-type events are no longer auto-classified unless `trafficType` is already set or the event is MCP, which regresses analytics tagging for existing `agent_`/`llms_request`/`markdown_request`/`skill_request` flows.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| asString(properties.crawler) ?? | ||
| asString(asRecord(properties.bot).provider) ?? | ||
| detectedAgent ?? | ||
| (protocolAgent || explicitAgent ? inferAgentProvider(event) : undefined); |
Contributor
There was a problem hiding this comment.
P1: Agent-type events are no longer auto-classified unless trafficType is already set or the event is MCP, which regresses analytics tagging for existing agent_/llms_request/markdown_request/skill_request flows.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/docs/src/cloud-analytics.ts, line 190:
<comment>Agent-type events are no longer auto-classified unless `trafficType` is already set or the event is MCP, which regresses analytics tagging for existing `agent_`/`llms_request`/`markdown_request`/`skill_request` flows.</comment>
<file context>
@@ -137,20 +132,66 @@ function inferAgentProvider(event: DocsAnalyticsEvent) {
asString(asRecord(properties.bot).provider) ??
- inferAgentProvider(event);
+ detectedAgent ??
+ (protocolAgent || explicitAgent ? inferAgentProvider(event) : undefined);
+
+ if (!explicitAgent && !protocolAgent && !detectedAgent && !agentProvider) {
</file context>
Suggested change
| (protocolAgent || explicitAgent ? inferAgentProvider(event) : undefined); | |
| inferAgentProvider(event); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Improves Docs Cloud analytics to reliably tag agent/bot traffic and infer provider names from user-agent and protocol hints. Passes
userAgentthroughpackages/docsandpackages/fumadocsso events are normalized server-side without extra work.New Features
mcpormcp_*), and agent-facing types (agent_*,agents_request,llms_request,markdown_request,skill_request).trafficType="agent"and fillagentName/botProvideronly when not provided; use "MCP client", "Docs agent", or "Docs reader" as needed.getDocsRequestAnalyticsProperties(request)inpackages/docs(exported fromindexandserver); includeuserAgentacrosspackages/fumadocsendpoints (spec, markdown, llms, search, feedback) and Ask AI.Bug Fixes
ClaudeBot/1.0), and avoid false positives for normal browsers (Mozilla/5.0).Written for commit 0240048. Summary will update on new commits.