[claude-tmgbedu]

Every table seeder generated by the seed command crashed when it was seeded:

TypeError: 'NoneType' object can't be awaited

create_seed.stub generated a synchronous def run(self) with docstrings. Seeder awaits run() in call, run_database_seed and run_specific_seed.

Fix

• The stub now generates async def run(self) -> None with no docstrings. The import from fastapi_startkit.masoniteorm.seeders import Seeder was already correct.
• Seeder is unchanged.
• ADR 033 and its index row are added.

Validation

• A new test generates PostTableSeeder with MakeSeedCommand. It checks the import, the async def run and that there are no docstrings. It then runs the seeder through Seeder.run_specific_seed, which imports it and awaits run().
• The test fails on the old stub. Running the old stub's output through run_specific_seed raises the TypeError above.
• Full suite, without the live-Postgres tests: 3044 passed, 10 skipped. Ruff is clean.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[claude-tmgbedu]

Review verdict: APPROVE (posted as a comment because gh approve fails on the same account). Not merged.

Checked:

• The stub now generates async def run(self) -> None with no docstrings. The import fastapi_startkit.masoniteorm.seeders.Seeder is correct, and Seeder.call, run_database_seed and run_specific_seed all await run().
• The new test generates PostTableSeeder through MakeSeedCommand and runs it through Seeder.run_specific_seed. With the old stub restored it fails on the async def run assertion. The unfixed stub's sync run() would also hit the TypeError in the ADR's await path.
• The test does not leak files. It writes under the per-test temp cwd, which tearDown removes. It also removes the sys.path entry and the generated_seeds modules.
• ADR 033 follows the repo format, and its row in docs/adr/AGENTS.md is correct. No other open PR uses 033; 027-032 and 034 belong to Structural (Protocol) config classes for app and database settings #293, Fix make command stubs, register db:make:observer, fix db:make:model flags #294, Fix db:migrate:fresh/refresh --seed and register db:migrate:refresh #295, Feature/caches #304-Cache.lock(): atomic locks for array, file and database stores #307 and Cache.tags(): namespaced tagged cache with tagged flush #309.
• No new comments or docstrings in the diff.
• uv run pytest tests -q --ignore=tests/masoniteorm/postgres passes, and ruff check and ruff format --check are clean.

Conflict with #294: yes, but only textual. Merging #294 into this branch conflicts in test_make_commands.py (the adjacent import lines, Seeder here and Model there) and in docs/adr/AGENTS.md (adjacent index rows 028 and 033). Whichever merges second needs a trivial rebase that keeps both imports and both rows; ADR index order should be 026, 028, 033.

Nit (non-blocking): the test reads the generated file with a bare open(...).read(), which leaves the handle open until it is garbage collected.