Add optional soft delete support#2032
Closed
Sakura0122 wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for your interest! We've recently updated contribution guidelines and PR description template, now we ask people not to open PRs unless maintainers explicitly ask to do it (see). If you are interested in this feature being added to SQLMOdel, please open a discussion or find existing one and upvote\comment on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Discussion: #1890
Description
This follows up on #1890, which was closed due to inactivity.
This PR adds optional soft delete support with:
SoftDeleteMixin, usingdeleted_atby defaultSoftDeleteSession.delete(), which marks soft-deletable models as deletedSoftDeleteSession.exec(select(...))include_deleted=Trueto include soft-deleted rows__soft_delete_field__Compared with #1890, this keeps the change scoped to the soft delete feature and adds query filtering support.
Checklist