Use content-type fast parse#472
Open
blakeembrey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preamble: I know
fast-content-type-parseis intended to be a Fastify fork ofcontent-typeand is likely forked for historical reasons, but I recently released acontent-type@2and the changes seemed relevant to this package. Mostly because there's no need to parse parameters at all.Changes
fast-content-type-parseto usecontent-typewithparameters: falseto extract thecontent-typeparameter.However, the parser in
content-typeno longer validates during parse (designed to be lenient/fast) so there is a minor behavior change with invalid MIME types. If you sent something likefooit would currently throw during.parsebut in this change it'll forwardfooalong.Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct