Skip to content

fix: support cookie v2.x#297

Merged
climba03003 merged 1 commit into
mainfrom
fix/support-cookie-v2
Jul 9, 2026
Merged

fix: support cookie v2.x#297
climba03003 merged 1 commit into
mainfrom
fix/support-cookie-v2

Conversation

@Tony133

@Tony133 Tony133 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Proposal:

Note:

@Tony133
Tony133 marked this pull request as ready for review July 9, 2026 07:59
@Tony133
Tony133 requested a review from a team July 9, 2026 07:59
@climba03003
climba03003 merged commit 80b6af5 into main Jul 9, 2026
17 checks passed
@climba03003
climba03003 deleted the fix/support-cookie-v2 branch July 9, 2026 10:06
@Eomm

Eomm commented Jul 9, 2026

Copy link
Copy Markdown
Member

We must release it as major since node.js 20 is no more supported

image

@climba03003

climba03003 commented Jul 9, 2026

Copy link
Copy Markdown
Member

We must release it as major since node.js 20 is no more supported
image

Not really, require(ESM) is support by node@20.17.0.
We actually only support (or test against) the latest version of each major version.
If it is not supported, the CI will throw red signal.

@Eomm

Eomm commented Jul 10, 2026

Copy link
Copy Markdown
Member

Ok, but I'm not talking about CI green/red, but about support: now the cookie v2 team can land something that is not included in node20.x.

If the CI turns read, it means users will have red CIs as well and we will need to:

  • pin the prev v2 version
  • rollback this PR

We will handle in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants