Repository navigation
feat(benchmarks): add POST results with a GET/POST toggle - #516
Merged
Merged
Conversation
Download benchmark-results-post.json from fastify/benchmarks alongside the GET results and show it on /benchmarks behind a GET/POST toggle. `#post` links straight to the POST view. Missing POST results are not fatal: the download writes an empty list and the page renders GET only, as before. The homepage stays GET-only.
Match the other components' scripts and keep the toggle type-checked. A `#post` link now briefly shows GET before switching, which is fine.
The script sat after </BaseLayout>, so it was emitted after </html>.
Tony133
approved these changes
Oct 19, 2026
ilteoood
reviewed
Oct 19, 2026
- Rename the scenario `results` field to `sourceFile`. - Require the `benchmarks` prop on BenchBars and pass the GET data from the homepage explicitly. - Use a boolean for `aria-selected`. - Exclude the generated benchmarks-post.json from Biome.
Member
Author
|
Why can't I see the deployment? I think it failed @Eomm |
Member
It failed with success on deploy ✅ It seems that the secrets of the repo have been deleted. @Eomm do you still have them? |
Member
I can see the secret but the value is removed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download benchmark-results-post.json from fastify/benchmarks alongside the GET results and show it on /benchmarks behind a GET/POST toggle.
#postlinks straight to the POST view.Missing POST results are not fatal: the download writes an empty list and the page renders GET only, as before. The homepage stays GET-only.