Fix deadlocks and concurrency issues in provider and sequencer components#1347
Closed
khyatimahendru wants to merge 3 commits into
Closed
Fix deadlocks and concurrency issues in provider and sequencer components#1347khyatimahendru wants to merge 3 commits into
khyatimahendru wants to merge 3 commits into
Conversation
…ents - PubberBacnetProvider: Removed synchronized blocks on long-running provider methods and replaced ArrayDeque with ConcurrentLinkedDeque. This decouples the methods from the main executor threads, resolving a deadlock where discovery scan stops were blocked by synchronous internal logging. - SequenceBase: Replaced ArrayDeque with a thread-safe LinkedBlockingDeque for the message queue to safely support concurrent processing.
Fixes a race condition where the default 10-second timeout in waitUntil for expected states would perfectly collide with the device's simulated 10-second writeback delay. Added MAX_WAIT_TIME (20 seconds) to provide sufficient buffer for network transit and device processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.