refactor(lib): Remove ISF namespace remnants and modernize namespace usage - #108
Merged
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR converts nearly all headers in the codebase from traditional ChangesHeader guards and MLogging namespace migration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jbeirer
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@include/FastCaloSim/LinkDef.h`:
- Around line 590-594: The ROOT rename rule for MLogging is incomplete because
`#pragma` read with only sourceClass and targetClass will not trigger schema
evolution; update the rule in LinkDef.h to include either a version or checksum
selector so the old ISF_FCS::MLogging streamer info is actually mapped to
FastCaloSim::MLogging. Keep ROOT::AddClassAlternate in MLogging.cxx as a
separate alias, but ensure this I/O rule explicitly matches the legacy schema
using the existing class names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 04d39456-93c1-4ade-bcb9-ae6ee5a256e0
📒 Files selected for processing (121)
include/FastCaloSim/Core/DoubleArray.hinclude/FastCaloSim/Core/ISF_FastCaloSimEventDict.hinclude/FastCaloSim/Core/IntArray.hinclude/FastCaloSim/Core/MLogging.hinclude/FastCaloSim/Core/TFCS1DFunction.hinclude/FastCaloSim/Core/TFCS1DFunctionHistogram.hinclude/FastCaloSim/Core/TFCS1DFunctionInt16Histogram.hinclude/FastCaloSim/Core/TFCS1DFunctionInt32Histogram.hinclude/FastCaloSim/Core/TFCS1DFunctionRegression.hinclude/FastCaloSim/Core/TFCS1DFunctionRegressionTF.hinclude/FastCaloSim/Core/TFCS1DFunctionSpline.hinclude/FastCaloSim/Core/TFCS1DFunctionTemplateHelpers.hinclude/FastCaloSim/Core/TFCS1DFunctionTemplateHistogram.hinclude/FastCaloSim/Core/TFCS1DFunctionTemplateInterpolationHistogram.hinclude/FastCaloSim/Core/TFCS2DFunction.hinclude/FastCaloSim/Core/TFCS2DFunctionHistogram.hinclude/FastCaloSim/Core/TFCS2DFunctionLateralShapeParametrization.hinclude/FastCaloSim/Core/TFCS2DFunctionTemplateHistogram.hinclude/FastCaloSim/Core/TFCS2DFunctionTemplateInterpolationExpHistogram.hinclude/FastCaloSim/Core/TFCS2DFunctionTemplateInterpolationHistogram.hinclude/FastCaloSim/Core/TFCSBinnedShower.hinclude/FastCaloSim/Core/TFCSBinnedShowerBase.hinclude/FastCaloSim/Core/TFCSBinnedShowerONNX.hinclude/FastCaloSim/Core/TFCSCenterPositionCalculation.hinclude/FastCaloSim/Core/TFCSEnergyAndHitGANV2.hinclude/FastCaloSim/Core/TFCSEnergyBinParametrization.hinclude/FastCaloSim/Core/TFCSEnergyInterpolationHistogram.hinclude/FastCaloSim/Core/TFCSEnergyInterpolationLinear.hinclude/FastCaloSim/Core/TFCSEnergyInterpolationPiecewiseLinear.hinclude/FastCaloSim/Core/TFCSEnergyInterpolationSpline.hinclude/FastCaloSim/Core/TFCSEnergyParametrization.hinclude/FastCaloSim/Core/TFCSEnergyRenormalization.hinclude/FastCaloSim/Core/TFCSExtrapolationState.hinclude/FastCaloSim/Core/TFCSFlatLateralShapeParametrization.hinclude/FastCaloSim/Core/TFCSFunction.hinclude/FastCaloSim/Core/TFCSGANEtaSlice.hinclude/FastCaloSim/Core/TFCSGANLWTNNHandler.hinclude/FastCaloSim/Core/TFCSGANXMLParameters.hinclude/FastCaloSim/Core/TFCSHistoLateralShapeGausLogWeight.hinclude/FastCaloSim/Core/TFCSHistoLateralShapeGausLogWeightHitAndMiss.hinclude/FastCaloSim/Core/TFCSHistoLateralShapeParametrization.hinclude/FastCaloSim/Core/TFCSHistoLateralShapeParametrizationFCal.hinclude/FastCaloSim/Core/TFCSHistoLateralShapeWeight.hinclude/FastCaloSim/Core/TFCSHistoLateralShapeWeightHitAndMiss.hinclude/FastCaloSim/Core/TFCSHitCellMapping.hinclude/FastCaloSim/Core/TFCSHitCellMappingFCal.hinclude/FastCaloSim/Core/TFCSHitCellMappingWiggle.hinclude/FastCaloSim/Core/TFCSHitCellMappingWiggleEMB.hinclude/FastCaloSim/Core/TFCSInitWithEkin.hinclude/FastCaloSim/Core/TFCSInvisibleParametrization.hinclude/FastCaloSim/Core/TFCSLateralShapeParametrization.hinclude/FastCaloSim/Core/TFCSLateralShapeParametrizationFixedHitChain.hinclude/FastCaloSim/Core/TFCSLateralShapeParametrizationFluctChain.hinclude/FastCaloSim/Core/TFCSLateralShapeParametrizationHitBase.hinclude/FastCaloSim/Core/TFCSLateralShapeParametrizationHitChain.hinclude/FastCaloSim/Core/TFCSLateralShapeParametrizationHitNumberFromE.hinclude/FastCaloSim/Core/TFCSLateralShapeTuning.hinclude/FastCaloSim/Core/TFCSMLCalorimeterSimulator.hinclude/FastCaloSim/Core/TFCSNetworkFactory.hinclude/FastCaloSim/Core/TFCSONNXHandler.hinclude/FastCaloSim/Core/TFCSPCAEnergyParametrization.hinclude/FastCaloSim/Core/TFCSParametrization.hinclude/FastCaloSim/Core/TFCSParametrizationAbsEtaSelectChain.hinclude/FastCaloSim/Core/TFCSParametrizationBase.hinclude/FastCaloSim/Core/TFCSParametrizationBinnedChain.hinclude/FastCaloSim/Core/TFCSParametrizationChain.hinclude/FastCaloSim/Core/TFCSParametrizationEbinChain.hinclude/FastCaloSim/Core/TFCSParametrizationEkinSelectChain.hinclude/FastCaloSim/Core/TFCSParametrizationEtaSelectChain.hinclude/FastCaloSim/Core/TFCSParametrizationFloatSelectChain.hinclude/FastCaloSim/Core/TFCSParametrizationPDGIDSelectChain.hinclude/FastCaloSim/Core/TFCSParametrizationPlaceholder.hinclude/FastCaloSim/Core/TFCSPhiModulationCorrection.hinclude/FastCaloSim/Core/TFCSPredictExtrapWeights.hinclude/FastCaloSim/Core/TFCSSimpleLWTNNHandler.hinclude/FastCaloSim/Core/TFCSSimulationState.hinclude/FastCaloSim/Core/TFCSTruthState.hinclude/FastCaloSim/Core/TFCSVoxelHistoLateralCovarianceFluctuations.hinclude/FastCaloSim/Core/VNetworkBase.hinclude/FastCaloSim/Core/VNetworkLWTNN.hinclude/FastCaloSim/Extrapolation/FastCaloSimCaloExtrapolation.hinclude/FastCaloSim/Geometry/MeanAndRMS.hinclude/FastCaloSim/LinkDef.hinclude/FastCaloSim/Transport/G4CaloTransportTool.hparam/include/FastCaloSimParam/FCS_Cell.hsource/Core/MLogging.cxxsource/Core/TFCS1DFunction.cxxsource/Core/TFCS2DFunction.cxxsource/Core/TFCS2DFunctionLateralShapeParametrization.cxxsource/Core/TFCSCenterPositionCalculation.cxxsource/Core/TFCSEnergyAndHitGANV2.cxxsource/Core/TFCSEnergyBinParametrization.cxxsource/Core/TFCSEnergyInterpolationHistogram.cxxsource/Core/TFCSEnergyInterpolationLinear.cxxsource/Core/TFCSEnergyInterpolationPiecewiseLinear.cxxsource/Core/TFCSEnergyInterpolationSpline.cxxsource/Core/TFCSEnergyRenormalization.cxxsource/Core/TFCSFlatLateralShapeParametrization.cxxsource/Core/TFCSHistoLateralShapeParametrization.cxxsource/Core/TFCSHistoLateralShapeWeight.cxxsource/Core/TFCSHitCellMapping.cxxsource/Core/TFCSHitCellMappingWiggle.cxxsource/Core/TFCSLateralShapeParametrization.cxxsource/Core/TFCSLateralShapeParametrizationFluctChain.cxxsource/Core/TFCSLateralShapeParametrizationHitChain.cxxsource/Core/TFCSLateralShapeParametrizationHitNumberFromE.cxxsource/Core/TFCSNetworkFactory.cxxsource/Core/TFCSPCAEnergyParametrization.cxxsource/Core/TFCSParametrizationBase.cxxsource/Core/TFCSParametrizationBinnedChain.cxxsource/Core/TFCSParametrizationChain.cxxsource/Core/TFCSPredictExtrapWeights.cxxsource/Core/TFCSVoxelHistoLateralCovarianceFluctuations.cxxsource/Extrapolation/FastCaloSimCaloExtrapolation.cxxtest/TestConfig/AtlasSimTestsConfig.htest/TestConfig/AtlasTransportTestsConfig.htest/TestPlugins/ATLAS/ATLASMagneticFieldMapPlugin/src/AtlasFieldSvc.cxxtest/TestPlugins/ATLAS/ATLASMagneticFieldMapPlugin/src/H8FieldSvc.cxxtest/include/BasicExtrapolTests.htest/source/AtlasSimTests.cxxtest/source/BasicSimTests.cxx
💤 Files with no reviewable changes (2)
- include/FastCaloSim/Core/ISF_FastCaloSimEventDict.h
- test/TestPlugins/ATLAS/ATLASMagneticFieldMapPlugin/src/H8FieldSvc.cxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the remaining ISF-era identifiers now that FastCaloSim is being integrated into Athena as the replacement for the legacy ISF FastCaloSim implementation.
Changes
ISF_FCS::MLoggingtoFastCaloSim::MLoggingFCS_MSGenum into theFastCaloSim::MSGnamespaceFCS_MSG_*macros are intentionally kept, as macros cannot be namespaced and bareMSG::*names would conflict with Gaudi'sMSGnamespace inside Athena.ISF_*include guards with#pragma once, matching the style already used in the newer Geometry, Definitions, and test code.ISF_FastCaloSimEventDict.hheader and outdated ISF-related comments.Backward Compatibility
Existing parametrization files embed
ISF_FCS::MLoggingin their ROOT streamer information (standalonev0entry and the base-class elements ofTFCSFunctionandTFCSParametrizationBase). To preserve compatibility with these files, this PR includes:ROOT::AddClassAlternate("FastCaloSim::MLogging", "ISF_FCS::MLogging")during library initialization in
MLogging.cxx(this is not generated automatically byrootcling).ISF_FCS::MLoggingtoFastCaloSim::MLogging.ClassDefversion bumps for all persistent classes directly inheriting fromMLogging, since the base-class name contributes to the ROOT class checksum.Closes #81