[DOC] update categorical encoders user guide#919
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 116 116
Lines 4978 4978
Branches 795 795
=======================================
Hits 4892 4892
Misses 55 55
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| .. math:: | ||
| a_{subindex} = a_i cw | ||
| b_{bin_index} = Min + cw^{bin_index} |
There was a problem hiding this comment.
Hi @glevv
I am updating the docs for various classes, and in doing so, I noticed that what we had as explanation for how the geometric discretiser works did not match the code output that was produced by the class. So evidently, the documentation is wrong, in the sense, that it does not explain what the class does.
Claude said that I need to update the formula like this to match the code base. Would you agree?
There was a problem hiding this comment.
He wrote the formula straight out of the code, it is fine. The original formula tried to convey the general idea of geometric progression, the new is closer to the specific implementation
There was a problem hiding this comment.
They are both fine IMO, but the Claude version is closer to the code
|
|
||
| .. math:: | ||
| a_{i+1} = a_i cw | ||
| b_i = Min + cw^i |
There was a problem hiding this comment.
Could you also check whether these changes make sense?
There was a problem hiding this comment.
awesome, thank you!
2 participants
No description provided.