FuseERC4626 Vaults : unit & integration tests#6
Open
eswak wants to merge 10 commits into
Open
Conversation
Joeysantoro
reviewed
Mar 28, 2022
Joeysantoro
reviewed
Mar 28, 2022
Joeysantoro
reviewed
Mar 29, 2022
Joeysantoro
reviewed
Mar 29, 2022
| returns (uint256) | ||
| { | ||
| require(amount != 0, "ZERO_ASSETS"); // Deposit 0 makes no sense | ||
| require(amount <= type(uint128).max, "MANY_ASSETS"); // Check for overly large values |
Contributor
There was a problem hiding this comment.
why add this uint128 check? I don't think its necessary
Author
There was a problem hiding this comment.
on large values the CToken fails with MINT_EXCHANGE_CALCULATION_FAILED and there can be issues with wadMul, better to put a boundary (uint128.max is pretty large already)
Contributor
There was a problem hiding this comment.
right but its gas intensive to add. In practice token values don't get this large
Joeysantoro
approved these changes
Apr 4, 2022
Author
|
Deploy script : |
Author
|
Deployed : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds npm scripts to run unit and integration tests :
npm run testto run unit testsnpm run test:integrationto run integration tests with a fixed block numbernpm run test:integration:latestto run integration tests using the latest blockUnit tests are added for

FuseERC4626:And integration tests are added for

Fuse ERC4626: