Add an option to create PDF outlines (chapter bookmarks) based on header structure.#5
Open
WiDuMu wants to merge 5 commits into
Open
Add an option to create PDF outlines (chapter bookmarks) based on header structure.#5WiDuMu wants to merge 5 commits into
WiDuMu wants to merge 5 commits into
Conversation
Owner
|
I like the idea. Are you still working on this? |
Contributor
Author
|
Yes, I'm not happy with the configuration options (you should be able to set what headers get put into the outline), and it's behavior with weird header arrangents, it's a work in progress. |
Contributor
Author
|
On further examination, it seems that there is not a required update in pdfkit, only the typescript types for development to at least |
Contributor
Author
|
I did mark it ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be helpful for some markdown documents to create chapter bookmarks (in PDF parlance, an outline) based on the headers put into the document. This PR aims to add this functionality to pdfkit-markdown.
This would involve updating to a version 0.17 of pdfkit and adding some coordinating logic.
Before:
After: