Skip to content

Fix e2e tests: add proper health check for WordPress Playground #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fellyph wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix e2e tests: add proper health check for WordPress Playground #20

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b49d40a
Fix e2e tests: add proper health check for WordPress Playground
claude Jan 10, 2026
3a269a4
Fix CI: pin Node.js to v20 and improve error handling
claude Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions tests/global-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,37 @@ async function globalSetup(): Promise<void> {
// eslint-disable-next-line no-console
console.log('WordPress Playground server started on http://127.0.0.1:9400');

// Wait a bit for the server to be fully ready
await new Promise<void>((resolve) => setTimeout(resolve, 2000));
// Wait for WordPress to be fully ready by polling the health endpoint
const maxAttempts = 30;
const delayMs = 2000;
let attempts = 0;

while (attempts < maxAttempts) {
try {
const response = await fetch('http://127.0.0.1:9400/wp-admin/');
if (response.ok || response.status === 302) {
Comment on lines +67 to +82
Copy link
Copy Markdown

@github-actions github-actions Bot Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 It's a good practice to avoid hardcoding URLs and ports in test files. Defining the base URL as a constant at the top of the polling logic will improve maintainability and make it easier to update if the port or host changes.

Suggested change
const delayMs = 2000;
let attempts = 0;
while (attempts < maxAttempts) {
try {
const response = await fetch('http://127.0.0.1:9400/wp-admin/');
if (response.ok || response.status === 302) {
const BASE_URL = 'http://127.0.0.1:9400';
const maxAttempts = 30;
const delayMs = 2000;
let attempts = 0;
while (attempts < maxAttempts) {
try {
const response = await fetch(`${BASE_URL}/wp-admin/`);

// eslint-disable-next-line no-console
console.log(`WordPress is ready after ${attempts + 1} attempt(s)`);
break;
}
} catch {
// Server not ready yet, continue polling
}

attempts++;
if (attempts < maxAttempts) {
// eslint-disable-next-line no-console
console.log(`Waiting for WordPress to be ready... (attempt ${attempts}/${maxAttempts})`);
await new Promise<void>((resolve) => setTimeout(resolve, delayMs));
}
}

if (attempts >= maxAttempts) {
throw new Error('WordPress Playground failed to start within the expected time');
}

// Additional wait for plugin initialization
await new Promise<void>((resolve) => setTimeout(resolve, 1000));
}

export default globalSetup;
Loading