Update packages to latest version#85
Conversation
Also update files where new ESLint errors were caught, and fix syntax where this has changed in test files
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
daurnimator
left a comment
daurnimator
left a comment
There was a problem hiding this comment.
fix syntax where this has changed in test files,
I don't see that in the PR?
and add new ESLint config
It indeed looks like there is a new config format (https://eslint.org/docs/latest/use/configure/configuration-files vs https://eslint.org/docs/latest/use/configure/configuration-files-deprecated).
Thanks!
daurnimator
left a comment
daurnimator
left a comment
There was a problem hiding this comment.
Thankyou!
I'll squash merge this now.
In future I'd love it if you could amend/fixup your commits as you go, rather than pushing new ones at the end in response to review
I find the script at https://github.com/hashbang/dotfiles/blob/9d4ffd7e33814df1dfabcd48aca26a30ac6ee6f2/git/.local/bin/git-fixup#L1 to be very useful for working in git.
|
uh sorry, I didn't see that CI was failing. My first guess is that |
Update ci workflow with currently supported NodeJS version Add variable to catch statement Add appropriate eslint-disable directive Update ESLint config Add Node 20 to CI script Updated CI script versions
droberts-ctrlo
force-pushed
the
package-upgrades
branch
from
cb7b7cf to
81b3ba2
Compare
|
Merged! |
2 participants
Also update files where new ESLint errors were caught,
fix syntax where this has changed in test files,
and add new ESLint config