Auto-populate scope["user"] with BfabricUser in BfabricAuthMiddleware#483
Merged
leoschwarz merged 3 commits intomainfrom Apr 15, 2026
Merged
Auto-populate scope["user"] with BfabricUser in BfabricAuthMiddleware#483leoschwarz merged 3 commits intomainfrom
leoschwarz merged 3 commits intomainfrom
Conversation
Add BfabricUser class implementing Starlette's BaseUser protocol that wraps SessionData and provides is_authenticated, display_name, identity, session_data, and get_bfabric_client(). The middleware now automatically sets scope["user"] on authenticated requests, eliminating the need for boilerplate CopyUserMiddleware in apps. Closes #427
- Remove session_data property to avoid exposing raw password
- Add login and instance properties for safe access
- Change identity format from "{instance}:{login}" to "{login}@{instance}"
- Add unit tests for BfabricUser
- Update BDD tests to match new API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BfabricUserclass (StarletteBaseUserprotocol) wrappingSessionDatascope["user"]on authenticated requests, sorequest.userworks out of the boxCopyUserMiddlewareCloses #427