Fix UpdateCommandPaletteSuggestions#18496
Open
KrisVandermotten wants to merge 1 commit into
Open
Conversation
Member
|
Thanks! I'll try to take a look and test these changes sometime this week or next week. |
Member
|
I'm having a hard time testing these changes since I still can't reproduce the issue. @Josh65-2201 did you have any luck on your end? |
Member
|
Haven't reproduce it, @KrisVandermotten Whats your Files set language, Windows language and keyboard layout? I can only think it would be one of those settings causing it to not be consistent. |
Contributor
Author
Windows language is Files is set to use the system language. |
Member
|
I can reproduce it in 4.1.1, with Files language set to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
The new code is much simpler than the old code, more straightforward and more efficient.
Steps used to test these changes
This only fixes the bug mentioned above. It does not attempt to fix any of the other issues in the command palette.
This was tested using the same steps as in #18486, on a machine running in
nl-BE. No new issues are introduced compared to main.