Feature: Add ZIP encoding selection support for browsing archives with non-UTF-8 filenames#18529
Open
oxygen-dioxide wants to merge 4 commits into
Open
Feature: Add ZIP encoding selection support for browsing archives with non-UTF-8 filenames#18529oxygen-dioxide wants to merge 4 commits into
oxygen-dioxide wants to merge 4 commits into
Conversation
Contributor
Author
|
Problem: users still can't double-click a file in the archive to open it because process.Start() doesn't support custom zip encoding. (However, this bug also occurs for 7z files, so I may create another PR to fix it.) |
oxygen-dioxide
force-pushed
the
zip-encoding-oc
branch
from
c9d280e to
722fb3c
Compare
yair100
reviewed
May 31, 2026
| Spacing="4"> | ||
|
|
||
| <!-- ZIP Encoding Selector --> | ||
| <ComboBox |
Member
There was a problem hiding this comment.
Please send a screenshot of this UI. I'm not sure the toolbar is the correct placement for a ComboBox.
Member
There was a problem hiding this comment.
What are the other options in the dropdown?
Contributor
Author
There was a problem hiding this comment.
It's the same as in my PR #17045, which is all possible ANSI encoding in Windows.
public static EncodingItem[] Defaults = new string?[] {
null,//System Default
"UTF-8",
//All possible Windows system encodings
//reference: https://en.wikipedia.org/wiki/Windows_code_page
//East Asian
"shift_jis", //Japanese
"gb2312", //Simplified Chinese
"big5", //Traditional Chinese
"ks_c_5601-1987", //Korean
//Southeast Asian
"Windows-1258", //Vietnamese
"Windows-874", //Thai
//Middle East
"Windows-1256", //Arabic
"Windows-1255", //Hebrew
"Windows-1254", //Turkish
//European
"Windows-1252", //Western European
"Windows-1250", //Central European
"Windows-1251", //Cyrillic
"Windows-1253", //Greek
"Windows-1257", //Baltic
"macintosh",
}
.Select(x => new EncodingItem(x))
.ToArray();
Member
There was a problem hiding this comment.
The bottom right corner of the status bar might be a better location. Fyi @mdtauk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When opening a ZIP archive whose filenames use an encoding other than the user's OS encoding, the filenames appear garbled
Solution
Added a ComboBox in the navigation toolbar that appears when browsing a ZIP archive with undetermined encoding, allowing the user to select the appropriate character encoding. When a custom encoding is selected, the app switches from SevenZipSharp to SharpZipLib to read filenames and file contents.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
previous behaviour:
current behaviour:
