Update StorageRing.xaml - Replace Storyboard with VisualState Setters#18532
Open
mdtauk wants to merge 1 commit into
Open
Update StorageRing.xaml - Replace Storyboard with VisualState Setters#18532mdtauk wants to merge 1 commit into
mdtauk wants to merge 1 commit into
Conversation
Based on what we are seeing with the WinUI Perf2026 changes, I thought I would start by updating our StorageRing to use VisualStateSetters, instead of Storyboards. I ran the UITests app and the control behaves the same as it did before. If possible, @0x5bfa could make some kind of test to ensure there is nothing that has been overlooked. It should just be 1:1 behaviour though, and I suppose if Microsoft felt moving from storyboards offered a performance improvement, there may be some gains from this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-05-30.164526.mp4
Based on what we are seeing with the WinUI Perf2026 changes, I thought I would start by updating our StorageRing to use VisualStateSetters, instead of Storyboards.
This does not close or resolve any existing issues
Steps used to test these changes
I ran the UITests app and the control behaves the same as it did before.
If possible, @0x5bfa could make some kind of test to ensure there is nothing that has been overlooked. It should just be 1:1 behaviour though, and I suppose if Microsoft felt moving from storyboards offered a performance improvement, there may be some gains from this change.