You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Refactor getDiff to store the diff into the action #1693
Is your feature request related to a problem? Please describe.
Right now, getDiff stores the diff as content in a step via step.setContent, making the diff harder to fetch from plugins (as of the plugin revamp #1683) and subsequent actions like scanDiff:
...
step.log(`Executing "git diff ${commitFrom}${action.commitTo}" in ${path}`);constrevisionRange=`${commitFrom}..${action.commitTo}`;constdiff=awaitgit.diff([revisionRange]);step.log(diff);step.setContent(diff);}catch(error: unknown){constmsg=getErrorMessage(error);step.setError(msg);}finally{action.addStep(step);}returnaction;
Describe the solution you'd like
Refactor getDiff so that adding the diff as content isn't necessary. We might need to look into why it was done this way in the first place. If we need to keep it as step content, we can just store the diff regardless via action.diff = diff, and then refactor any usages to use that instead.
@amnkarn Sure! Keep in mind we don't want to break the DB/diff display for current users. You might need to do some extra digging to find out how the diff is being used and what's safe to refactor.
Activity
amnkarn commentedon Aug 24, 2026
I'd like to work on this issue. Can you assign it to me?
jescalada commentedon Aug 24, 2026
@amnkarn Sure! Keep in mind we don't want to break the DB/diff display for current users. You might need to do some extra digging to find out how the diff is being used and what's safe to refactor.
refactor: store diff in action object (finos#1693)
Merge pull request #1701 from amnkarn/fix-1693