Skip to content

fix(auth): add MainActor annotation to email link and password recovery Views #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
russellwheatley merged 3 commits into from
Mar 31, 2026
+2 −0
Merged

fix(auth): add MainActor annotation to email link and password recovery Views #1333

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0782ea6
Added @MainActor to email link and password recovery views
megastep Mar 26, 2026
d76f9fc
Gemini recommendation: use reportError inside the catch block
megastep Mar 26, 2026
fb92bc8
Revert "Gemini recommendation: use reportError inside the catch block"
megastep Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/EmailLinkView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import FirebaseAuthUIComponents
import FirebaseCore
import SwiftUI

@MainActor
public struct EmailLinkView {
@Environment(AuthService.self) private var authService
@Environment(\.accountConflictHandler) private var accountConflictHandler
Expand Down
4 changes: 3 additions & 1 deletion FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/PasswordRecoveryView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ import FirebaseAuthUIComponents
import FirebaseCore
import SwiftUI

@MainActor
Comment thread
megastep marked this conversation as resolved.
public struct PasswordRecoveryView {
@Environment(AuthService.self) private var authService
@Environment(\.reportError) private var reportError
@State private var email = ""
@State private var showSuccessSheet = false
@State private var sentEmail = ""
Expand All @@ -30,7 +32,7 @@ public struct PasswordRecoveryView {
sentEmail = email
showSuccessSheet = true
} catch {
// Error already displayed via modal by AuthService
reportError?(error)
Comment thread
russellwheatley marked this conversation as resolved.
Outdated
}
}
}
Expand Down