Skip to content

Fix macOS Firestore linker error by adding Network framework dependency#1886

Merged
AustinBenoit merged 1 commit into
mainfrom
fix/macos-firestore-linker
Jul 21, 2026
Merged

Fix macOS Firestore linker error by adding Network framework dependency#1886
AustinBenoit merged 1 commit into
mainfrom
fix/macos-firestore-linker

Conversation

@AustinBenoit

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Fix macOS Firestore linker error by adding Network framework dependency


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Will verify firestore build works


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • [CX] Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AustinBenoit AustinBenoit added the skip-release-notes Skip release notes check label Jul 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the "Network" framework dependency to the CMake configuration files for both firestore/integration_test and firestore/integration_test_internal. There are no review comments, and I have no feedback to provide.

@AustinBenoit AustinBenoit added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Jul 14, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

⏳  Integration test in progress...

Requested by @AustinBenoit on commit 6c2d998
Last updated: Tue Jul 21 06:37 PDT 2026
View integration test log & download artifacts

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Jul 14, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 15, 2026
@AustinBenoit AustinBenoit added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Jul 20, 2026
@AustinBenoit
AustinBenoit merged commit 6c2d998 into main Jul 21, 2026
120 of 166 checks passed
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: in-progress This PR's integration tests are in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants