Skip to content

fix: add tzdata as a required dependency#276

Merged
IzaakGough merged 3 commits into
mainfrom
@invertase/add-tzdata-dep
Jun 5, 2026
Merged

fix: add tzdata as a required dependency#276
IzaakGough merged 3 commits into
mainfrom
@invertase/add-tzdata-dep

Conversation

@IzaakGough

@IzaakGough IzaakGough commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix scheduler test failures in environments that do not have timezone data installed by adding tzdata as a required dependency.

Problem/Root Cause

Issue #258 reports that test_on_schedule_call and test_on_schedule_decorator fail with ZoneInfoNotFoundError for America/Los_Angeles when the runtime environment does not have the tzdata package available.

The root cause is that the package relies on timezone data through Python's zoneinfo support, but tzdata was not listed in the project's required dependencies. That left installs dependent on environment-specific system timezone data being present.

Solution/Changes

Add tzdata>=2024.1 to the [project].dependencies list in pyproject.toml so timezone data is installed as part of the package's normal dependency set.

This removes the environment-specific dependency on preinstalled timezone data and ensures the scheduler code has access to the timezone definitions it needs in environments where system tzdata is missing.

Testing

  • Manually verified that this patch ensures that both tests pass in the following MRE.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the 'tzdata' dependency to 'pyproject.toml'. The feedback recommends removing an unnecessary blank line introduced at the end of the 'dependencies' list to maintain clean formatting.

Comment thread pyproject.toml Outdated
@IzaakGough IzaakGough marked this pull request as ready for review June 2, 2026 15:54
@IzaakGough IzaakGough requested a review from a team June 3, 2026 09:52

@CorieW CorieW left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cabljac

cabljac commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

lgtm!

@cabljac cabljac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IzaakGough IzaakGough merged commit 4688a11 into main Jun 5, 2026
20 checks passed
@cabljac cabljac deleted the @invertase/add-tzdata-dep branch June 8, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants