ABIU Experiment Code Cleanup#10638
Conversation
# Conflicts: # src/experiments.ts
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request graduates the Automatic Base Image Updates (ABIU) experiment to a standard feature by removing the 'abiu' experiment flag and all associated conditional checks, imports, and tests across App Hosting commands and setup functions. As a result, runtime selection and ABIU status reporting are now always enabled. Feedback on the changes suggests using the logical OR operator (||) instead of the nullish coalescing operator (??) when displaying the runtime value in the backends table, ensuring that empty strings correctly fall back to 'N/A'.
| abiuStatus = backend.automaticBaseImageUpdatesDisabled ? "Disabled" : "Enabled"; | ||
| } | ||
| row.push(abiuStatus); | ||
| row.push(backend.runtime?.value ?? "N/A"); |
There was a problem hiding this comment.
Using the nullish coalescing operator (??) here means that if backend.runtime?.value is an empty string (""), it will be pushed as "" instead of falling back to "N/A". Since an empty string is falsy, using the logical OR operator (||) will correctly fall back to "N/A" when the runtime value is empty, improving the table's readability.
| row.push(backend.runtime?.value ?? "N/A"); | |
| row.push(backend.runtime?.value || "N/A"); |
2 participants
Description
The experiment flag is now defaulted to true. This simplifies/cleans the code