ci: fix storage emulator integration tests on Node 24#10641
Open
joehan wants to merge 4 commits into
Open
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
### Description Node 20 is being deprecated from GitHub Actions. As part of upgrading our workflow: - The integration and integration-windows jobs have been updated to run on Node 22 (Active LTS). - This prevents a compatibility crash between the repository's Puppeteer v19 dependency and Node 24 (which clobbers file descriptors during child process spawning, causing Chrome to fail to launch with 'Invalid file descriptor to ICU data received'). - Other non-browser, single-version jobs remain on Node 24. - Multi-version jobs continue to cover Node 22 and 24. ### Scenarios Tested - Verified all GHA workflows, compilation, unit tests, and storage emulator integration tests pass successfully on GHA Node 22. ### Sample Commands None
joehan
force-pushed
the
jh-fix-storage-emulator-node-24
branch
from
c2e817d to
5969b34
Compare
…ll other integration tests This meets the GHA Node 20 deprecation rules by keeping all integration and windows-integration tests on Node 24, except the storage-emulator-integration test which runs on Node 22 (LTS) to avoid Puppeteer v19 compatibility crashes with Node 24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The storage emulator test was broken on Node 24 due to a puppeteer incompatibility. We'll need to update our version of puppeteer eventually to address this, but for now, we can just stick this on node 22