fix: correct function name length in validation error message to 63

src/deploy/functions/validate.ts

@@ -250,7 +250,7 @@
 
   const invalidList = invalidEndpoints
     .sort((a, b) => backend.compareFunctions(a.ep, b.ep))
     .map(({ ep, limit }) => `\t${getFunctionLabel(ep)}: ${ep.timeoutSeconds}s (limit: ${limit}s)`)
     .join("\n");
 
   const msg =
@@ -309,7 +309,7 @@
 /**
  * Validate function names only contain letters, numbers, underscores, and hyphens
  * and not exceed 63 characters in length.
  * @param functionNames Object containing function names as keys.
  * @throws { FirebaseError } Function names must be valid.
  */
 export function functionIdsAreValid(functions: { id: string; platform: string }[]): void {
@@ -319,7 +319,7 @@
   if (invalidIds.length !== 0) {
     const msg =
       `${invalidIds.map((f) => f.id).join(", ")} function name(s) can only contain letters, ` +
-      `numbers, hyphens, and not exceed 62 characters in length`;
+      `numbers, underscores, hyphens, and not exceed 63 characters in length`;
     throw new FirebaseError(msg);
   }
 }
@@ -330,7 +330,7 @@
  *
  * If validation fails for any secret config, throws a FirebaseError.
  */
 export async function secretsAreValid(projectId: string, wantBackend: backend.Backend) {
   const endpoints = backend
     .allEndpoints(wantBackend)
     .filter((e) => e.secretEnvironmentVariables && e.secretEnvironmentVariables.length > 0);
@@ -343,7 +343,7 @@
 /**
  * Ensures that all endpoints specifying secret environment variables target platform that supports the feature.
  */
 function validatePlatformTargets(endpoints: backend.Endpoint[]) {
   const unsupported = endpoints.filter((e) => !secretsSupportedPlatforms.includes(e.platform));
   if (unsupported.length > 0) {
     const errs = unsupported.map((e) => `${e.id}[platform=${e.platform}]`);
@@ -361,7 +361,7 @@
  *   1) It exists.
  *   2) It's in state "enabled".
  */
 async function validateSecretVersions(projectId: string, endpoints: backend.Endpoint[]) {
   const toResolve: Set<string> = new Set();
   for (const s of secrets.of(endpoints)) {
     toResolve.add(s.secret);
@@ -384,7 +384,7 @@
       if (sv.state !== "ENABLED") {
         errs.push(
           new FirebaseError(
             `Expected secret ${sv.secret.name}@${sv.versionId} to be in state ENABLED not ${sv.state}.`,
           ),
         );
       }