Skip to content

fix(database, iOS): prevent duplicate database instance initialization in FLTFirebaseDatabasePlugin #18373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SelaseKay wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(database, iOS): prevent duplicate database instance initialization in FLTFirebaseDatabasePlugin #18373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ..._database/ios/firebase_database/Sources/firebase_database/FLTFirebaseDatabasePlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,12 @@ public class FLTFirebaseDatabasePlugin: NSObject, FlutterPlugin, FLTFirebasePlug
app: DatabasePigeonFirebaseApp, host: String, port: Int64,
completion: @escaping (Result<Void, Error>) -> Void
) {
let instanceKey = databaseInstanceKey(app)
guard Self.cachedDatabaseInstances[instanceKey] == nil else {
completion(.success(()))
return
}

let database = getDatabaseFromPigeonApp(app)
database.useEmulator(withHost: host, port: Int(port))
completion(.success(()))
Expand Down Expand Up @@ -733,8 +739,12 @@ public class FLTFirebaseDatabasePlugin: NSObject, FlutterPlugin, FLTFirebasePlug

// MARK: - Helper Methods

private func databaseInstanceKey(_ app: DatabasePigeonFirebaseApp) -> String {
app.appName + (app.databaseURL ?? "")
}

private func getDatabaseFromPigeonApp(_ app: DatabasePigeonFirebaseApp) -> Database {
let instanceKey = app.appName + (app.databaseURL ?? "")
let instanceKey = databaseInstanceKey(app)

if let cachedInstance = Self.cachedDatabaseInstances[instanceKey] {
return cachedInstance
Expand Down
Loading