DO NOT MERGE! test merged solve block refactor branches#5239
Draft
angus-g wants to merge 8 commits into
Draft
Conversation
A bit of a doubling up on the already-present adj_sol on solver blocks.
* reduce nlvs adjoint test size * nlvs adjoint caching - bundle up recompute objects
We remove the explicit adjoint annotation on the bare solve() call, relying on the path through the NLVS as the single source of annotation. This simplifies and unifies the code paths, and will ideally allow us to remove the specialised solve blocks. Add CachedSolverBlock to get_solve_blocks check I don't think this affects anything, but should be there as a convenience function (referenced in the "extract adjoint solutions" notebook). Remove SolveLinearSystemBlock This is redundant now that it gets routed through the usual cached solver path.
Push subtraction out of derivative For whatever reason, derivative(-F, m, dm) has very different behaviour when passed through the adjoint -> action -> expand_derivatives chain compared to the non-negated variant. We just push subtraction to the dFdm_adj and dFdm_adj2 forms instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI run with merge of #5188 and #5226 to see where things stand (since they fail individually)