Petsc 64 bit int fixes#5252
Open
leo-collins wants to merge 8 commits into
Open
Conversation
Contributor
|
Thanks for this hard work! If you don't mind, would you be able to take this the last step of the way and enable int64 testing on CI? It'd be exactly the same as what we do for complex and single (in #5033). That would be really amazing. |
leo-collins
force-pushed
the
leo/petsc-int-fixes
branch
from
July 16, 2026 13:01
90f881d to
14f85c5
Compare
leo-collins
force-pushed
the
leo/petsc-int-fixes
branch
from
July 16, 2026 13:27
bae6480 to
14f85c5
Compare
| size_t ncells_ignore, | ||
| int* cells_ignore); | ||
| PetscReal *found_ref_cell_dist_l1, | ||
| PetscInt ncells_ignore, |
Member
There was a problem hiding this comment.
Is this always going to be large enough? Size_t is unsigned and comes with guarantees that int doesn't
| for (uint64_t i = 0; i < nids; i++) { | ||
| current_ref_cell_dist_l1 = (*try_candidate)(temp_ref_coords, f, ids[i], x); | ||
| for (uint64_t j = 0; j < ncells_ignore; j++) { | ||
| for (PetscInt j = 0; j < ncells_ignore; j++) { |
Member
There was a problem hiding this comment.
Same question here about int range
| PetscInt l = ids[i] % nlayers; | ||
| current_ref_cell_dist_l1 = (*try_candidate_xtr)(temp_ref_coords, f, c, l, x); | ||
| for (uint64_t j = 0; j < ncells_ignore; j++) { | ||
| for (PetscInt j = 0; j < ncells_ignore; j++) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5250 and #3913.
Use
PetscIntas much as we can essentially. Tested locally on a 64 bit Petsc build