Sum factorisation on simplices#5263
Open
pbrubeck wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jagged index support (gem + tsfc)
gem.JaggedIndexis a subclass ofIndexcarrying a parents tuple; its .extent stays the static rectangular bound, so every existing consumer that ignores jaggedness remains correct via the zero-padding invariant.In tsfc/loopy.py, a For loop over a jagged index nested inside its parents now gets a parametrized ISL domain ([p] -> {[q]: 0 <= q < E - p}); otherwise it silently falls back to the rectangular bound. The proof is an executed-kernel test: a 2D Morton-gather contraction compiled through compile_gem → tsfc.loopy.generate produces for (i_2 = 0; i_2 <= 4 + -1*i_1; ...) in the C and matches numpy to machine precision. duffy_evaluation now returns jagged lattice indices, so its consumers get the triangular loops for free.
Depends on firedrakeproject/fiat#262