Skip to content

Warn if PETSc is already initialised inside petsctools.init.#38

Merged
connorjward merged 2 commits into
mainfrom
connorjward/init-changes
Jul 10, 2026
Merged

Warn if PETSc is already initialised inside petsctools.init.#38
connorjward merged 2 commits into
mainfrom
connorjward/init-changes

Conversation

@connorjward

Copy link
Copy Markdown
Collaborator

This functionality was rejected from petsc4py and so should live here. It is unfortunately complicated due to the petsc4py init process.

Also tidies up some docstrings and moves some exceptions to exceptions.py which is now the established convention.

This functionality was rejected from petsc4py and so should live here.
It is unfortunately complicated due to the petsc4py init process.

Also tidies up some docstrings and moves some exceptions to
exceptions.py which is now the established convention.
@connorjward
connorjward requested a review from JHopeCollins June 15, 2026 12:56
@JHopeCollins

Copy link
Copy Markdown
Member

I'm sure I've seen this warning pop up when running the Firedrake test suite recently. Was I accidentally on this petsctools branch or a PETSc branch with the warning without realising or have I been hallucinating??

@connorjward

Copy link
Copy Markdown
Collaborator Author

I'm sure I've seen this warning pop up when running the Firedrake test suite recently. Was I accidentally on this petsctools branch or a PETSc branch with the warning without realising or have I been hallucinating??

See https://gitlab.com/petsc/petsc/-/merge_requests/9353.

It was in petsc4py but I then got asked to take it out.

@JHopeCollins

Copy link
Copy Markdown
Member

I'm sure I've seen this warning pop up when running the Firedrake test suite recently. Was I accidentally on this petsctools branch or a PETSc branch with the warning without realising or have I been hallucinating??

See gitlab.com/petsc/petsc/-/merge_requests/9353.

It was in petsc4py but I then got asked to take it out.

Gotcha. This looks fine then.

@connorjward
connorjward merged commit 4fda931 into main Jul 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants